[release-4.18] OCPBUGS-81520: Console can only show user name instead of full name as the display name#16238
Conversation
|
@Leo6Leo: This pull request references Jira Issue OCPBUGS-81520, which is valid. The bug has been moved to the POST state. 7 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
@Leo6Leo There is error when building the code: |
7ca39fc to
75656d9
Compare
|
Checked on cluster launched against the pr, login with openid connect idp user, the full name is shown as expected. |
|
@yanpzhan: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
75656d9 to
bbd8669
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Leo6Leo, logonoff The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
bbd8669 to
44f8f3c
Compare
|
New changes are detected. LGTM label has been removed. |
44f8f3c to
64135c2
Compare
…s the display name Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
64135c2 to
25b8c64
Compare
|
/retest-required |
5 similar comments
|
/retest-required |
|
/retest-required |
|
/retest-required |
|
/retest-required |
|
/retest-required |
|
@Leo6Leo: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Summary
release-4.18useUserhook that fetches the user resource and providesdisplayName,username, andfullNameuseTelemetryto includeuserResourcein telemetry events via the newuseUserhookTest plan
kube:adminstill displays correctlyuserResourcedatayarn testpasses foruseUser.spec.tsanduseTelemetry.spec.ts🤖 Generated with Claude Code