Skip to content

[release-4.18] OCPBUGS-81520: Console can only show user name instead of full name as the display name#16238

Open
Leo6Leo wants to merge 1 commit into
openshift:release-4.18from
Leo6Leo:leo/OCPBUGS-70334/show-full-user-name/4.18
Open

[release-4.18] OCPBUGS-81520: Console can only show user name instead of full name as the display name#16238
Leo6Leo wants to merge 1 commit into
openshift:release-4.18from
Leo6Leo:leo/OCPBUGS-70334/show-full-user-name/4.18

Conversation

@Leo6Leo
Copy link
Copy Markdown
Contributor

@Leo6Leo Leo6Leo commented Mar 31, 2026

Summary

Test plan

  • Verify the masthead toolbar displays the user's full name when set (e.g. via an identity provider that provides full names)
  • Verify the masthead toolbar falls back to username when no full name is available
  • Verify kube:admin still displays correctly
  • Verify telemetry events include the userResource data
  • Run unit tests: yarn test passes for useUser.spec.ts and useTelemetry.spec.ts

🤖 Generated with Claude Code

@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Mar 31, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@Leo6Leo: This pull request references Jira Issue OCPBUGS-81520, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.z) matches configured target version for branch (4.18.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-70335 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-70335 targets the "4.19.z" version, which is one of the valid target versions: 4.19.0, 4.19.z
  • bug has dependents

Requesting review from QA contact:
/cc @yanpzhan

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

Test plan

  • Verify the masthead toolbar displays the user's full name when set (e.g. via an identity provider that provides full names)
  • Verify the masthead toolbar falls back to username when no full name is available
  • Verify kube:admin still displays correctly
  • Verify telemetry events include the userResource data
  • Run unit tests: yarn test passes for useUser.spec.ts and useTelemetry.spec.ts

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Mar 31, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 5ab2e9c0-728e-400d-b0e7-c774c5fa3b01

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from jhadvig, spadgett and yanpzhan March 31, 2026 20:16
@openshift-ci openshift-ci Bot added component/core Related to console core functionality component/sdk Related to console-plugin-sdk component/shared Related to console-shared kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated labels Mar 31, 2026
@Leo6Leo Leo6Leo changed the title OCPBUGS-81520: Console can only show user name instead of full name as the display name [release-4.18] OCPBUGS-81520: Console can only show user name instead of full name as the display name Mar 31, 2026
@yanpzhan
Copy link
Copy Markdown
Contributor

yanpzhan commented Apr 1, 2026

@Leo6Leo There is error when building the code:

ERROR in packages/console-shared/src/hooks/__tests__/useUser.spec.ts:1:10
TS2305: Module '"react-redux"' has no exported member 'useSelector'.
  > 1 | import { useSelector, useDispatch } from 'react-redux';
      |          ^^^^^^^^^^^
    2 | import { useK8sGet } from '@console/internal/components/utils/k8s-get-hook';
    3 | import { testHook } from '../../../../../__tests__/utils/hooks-utils';
    4 | import { useUser } from '../useUser';

ERROR in packages/console-shared/src/hooks/__tests__/useUser.spec.ts:1:23
TS2305: Module '"react-redux"' has no exported member 'useDispatch'.
  > 1 | import { useSelector, useDispatch } from 'react-redux';
      |                       ^^^^^^^^^^^
    2 | import { useK8sGet } from '@console/internal/components/utils/k8s-get-hook';
    3 | import { testHook } from '../../../../../__tests__/utils/hooks-utils';
    4 | import { useUser } from '../useUser';

ERROR in packages/console-shared/src/hooks/__tests__/useUser.spec.ts:13:11
TS2339: Property 'requireActual' does not exist on type 'typeof jest'.
    11 |
    12 | jest.mock('react-redux', () => ({
  > 13 |   ...jest.requireActual('react-redux'),
       |           ^^^^^^^^^^^^^
    14 |   useSelector: jest.fn(),
    15 |   useDispatch: jest.fn(),
    16 | }));

ERROR in packages/console-shared/src/hooks/__tests__/useUser.spec.ts:28:11
TS2339: Property 'requireActual' does not exist on type 'typeof jest'.
    26 |
    27 | jest.mock('@console/dynamic-plugin-sdk', () => ({
  > 28 |   ...jest.requireActual('@console/dynamic-plugin-sdk'),
       |           ^^^^^^^^^^^^^
    29 |   getUser: jest.fn(),
    30 |   getUserResource: jest.fn(),
    31 |   setUserResource: (...args) => mockSetUserResource(...args),

ERROR in packages/console-shared/src/hooks/useUser.ts:3:10
TS2305: Module '"react-redux"' has no exported member 'useDispatch'.
    1 | import { useEffect } from 'react';
    2 | import { useTranslation } from 'react-i18next';
  > 3 | import { useDispatch, useSelector } from 'react-redux';
      |          ^^^^^^^^^^^
    4 | import { getUser, getUserResource, setUserResource } from '@console/dynamic-plugin-sdk';
    5 | import { useK8sGet } from '@console/internal/components/utils/k8s-get-hook';
    6 | import { UserModel } from '@console/internal/models';

ERROR in packages/console-shared/src/hooks/useUser.ts:3:23
TS2305: Module '"react-redux"' has no exported member 'useSelector'.
    1 | import { useEffect } from 'react';
    2 | import { useTranslation } from 'react-i18next';
  > 3 | import { useDispatch, useSelector } from 'react-redux';
      |                       ^^^^^^^^^^^
    4 | import { getUser, getUserResource, setUserResource } from '@console/dynamic-plugin-sdk';
    5 | import { useK8sGet } from '@console/internal/components/utils/k8s-get-hook';
    6 | import { UserModel } from '@console/internal/models';

@Leo6Leo Leo6Leo force-pushed the leo/OCPBUGS-70334/show-full-user-name/4.18 branch 2 times, most recently from 7ca39fc to 75656d9 Compare April 1, 2026 20:06
@openshift-ci openshift-ci Bot added the component/topology Related to topology label Apr 1, 2026
@yanpzhan
Copy link
Copy Markdown
Contributor

yanpzhan commented Apr 2, 2026

Checked on cluster launched against the pr, login with openid connect idp user, the full name is shown as expected.
/verified by @yanpzhan

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Apr 2, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@yanpzhan: This PR has been marked as verified by @yanpzhan.

Details

In response to this:

Checked on cluster launched against the pr, login with openid connect idp user, the full name is shown as expected.
/verified by @yanpzhan

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@Leo6Leo Leo6Leo force-pushed the leo/OCPBUGS-70334/show-full-user-name/4.18 branch from 75656d9 to bbd8669 Compare April 9, 2026 00:45
@openshift-ci-robot openshift-ci-robot removed the verified Signifies that the PR passed pre-merge verification criteria label Apr 9, 2026
Copy link
Copy Markdown
Member

@logonoff logonoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 15, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 15, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Leo6Leo, logonoff

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 15, 2026
@Leo6Leo Leo6Leo force-pushed the leo/OCPBUGS-70334/show-full-user-name/4.18 branch from bbd8669 to 44f8f3c Compare April 21, 2026 19:33
@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 21, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 21, 2026

New changes are detected. LGTM label has been removed.

@Leo6Leo Leo6Leo force-pushed the leo/OCPBUGS-70334/show-full-user-name/4.18 branch from 44f8f3c to 64135c2 Compare April 23, 2026 17:15
…s the display name

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@Leo6Leo Leo6Leo force-pushed the leo/OCPBUGS-70334/show-full-user-name/4.18 branch from 64135c2 to 25b8c64 Compare April 23, 2026 18:57
@Leo6Leo
Copy link
Copy Markdown
Contributor Author

Leo6Leo commented Apr 24, 2026

/retest-required

5 similar comments
@Leo6Leo
Copy link
Copy Markdown
Contributor Author

Leo6Leo commented Apr 27, 2026

/retest-required

@Leo6Leo
Copy link
Copy Markdown
Contributor Author

Leo6Leo commented Apr 28, 2026

/retest-required

@Leo6Leo
Copy link
Copy Markdown
Contributor Author

Leo6Leo commented May 1, 2026

/retest-required

@Leo6Leo
Copy link
Copy Markdown
Contributor Author

Leo6Leo commented May 5, 2026

/retest-required

@Leo6Leo
Copy link
Copy Markdown
Contributor Author

Leo6Leo commented May 6, 2026

/retest-required

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 6, 2026

@Leo6Leo: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-console 25b8c64 link true /test e2e-gcp-console

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/sdk Related to console-plugin-sdk component/shared Related to console-shared component/topology Related to topology jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants